third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html - Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial (Closed)

Patch Set: remove isInterstitialShowing setter Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/page_handler.cc ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

index 916d422d080c5706a2961b42ebc3661167d32013..fa121cb01bb44256f9f2886079c92a42f3af1fbc 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

@@ -19,6 +19,10 @@ function test()

// Test that the sidebar is hidden when an interstitial is shown. https://crbug.com/559150

InspectorTest.mainTarget.model(SDK.ResourceTreeModel).dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialShown);

+ // Simulate a request finishing after the interstitial is shown, to make sure that doesn't show up in the sidebar.

+ var request3 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);

+ request3.setSecurityState(Protocol.Security.SecurityState.Unknown);

+ InspectorTest.dispatchRequestFinished(request3);

InspectorTest.addResult("After interstitial is shown:");

InspectorTest.dumpDeepInnerHTML(Security.SecurityPanel._instance()._sidebarTree.element);