content/browser/devtools/protocol/page_handler.cc - Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial (Closed)

Patch Set: remove isInterstitialShowing setter Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index e1f72108baba64e55e48595971da9806aaa7e4ce..8ec2ef384357a89e0e6564967645810968d07bbc 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -198,6 +198,8 @@ void PageHandler::DidDetachInterstitialPage() {

Response PageHandler::Enable() {

enabled_ = true;

+ if (GetWebContents() && GetWebContents()->ShowingInterstitialPage())

+ client_->InterstitialShown(InterstitialShownParams::Create());

return Response::FallThrough();

}