Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2522673002: Check include order on cpp files as well (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Check include order on cpp files as well The check for include sorting was missing the cpp extension so was not running against any cpp files on upload. Committed: https://pdfium.googlesource.com/pdfium/+/d33c8e3145539631d03242a16c3683c3538c7557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. (doh)
4 years, 1 month ago (2016-11-21 21:17:42 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 21:18:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522673002/1
4 years, 1 month ago (2016-11-21 21:18:56 UTC) #5
npm
lgtm
4 years, 1 month ago (2016-11-21 21:19:05 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:31:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d33c8e3145539631d03242a16c3683c3538c...

Powered by Google App Engine
This is Rietveld 408576698