PRESUBMIT.py - Issue 2522673002: Check include order on cpp files as well - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(280)

My Issues | Starred Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2522673002: Check include order on cpp files as well (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 5ad2f545aeb67979bdd01a135b5cea02f4a522a7..db1bf00eb3c6cfadd21d0e809b699d95b933283a 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -239,7 +239,7 @@ def _CheckIncludeOrder(input_api, output_api):

warnings = []

for f in input_api.AffectedFiles(file_filter=FileFilterIncludeOrder):

- if f.LocalPath().endswith(('.cc', '.h', '.mm')):

+ if f.LocalPath().endswith(('.cc', '.cpp', '.h', '.mm')):

changed_linenums = set(line_num for line_num, _ in f.ChangedContents())

warnings.extend(_CheckIncludeOrderInFile(input_api, f, changed_linenums))

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698