Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2522663005: [Sync] Updated CookieJarMismatch to handle multiple sync cycles during OpenTabAndGetLocalWindows. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Updated CookieJarMismatch to handle multiple sync cycles during OpenTabAndGetLocalWindows. CookieJarMismatch occasionally failed because two sync cycles would happen for the upper or lower logic block, and then the histogram checks would fail. It is a little bit unclear if the two sync cycles were a result of the implementation of OpenTabAndGetLocalWindows(), or the extra TriggerSyncForModelTypes() afterwards. Regardless, we now check the histograms in a manner that is resilient to multiple sync cycles that duplicate the histogram emissions. BUG=663547 Committed: https://crrev.com/e1f491522b22424a488d6255ec1f066b0af45f8c Cr-Commit-Position: refs/heads/master@{#434024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -43 lines) Patch
M chrome/browser/sync/test/integration/sessions_helper.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 3 chunks +71 lines, -42 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
skym
PTAL
4 years, 1 month ago (2016-11-22 19:21:07 UTC) #4
maxbogue
lgtm
4 years, 1 month ago (2016-11-22 21:55:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522663005/1
4 years, 1 month ago (2016-11-22 23:14:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 23:47:49 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 23:50:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1f491522b22424a488d6255ec1f066b0af45f8c
Cr-Commit-Position: refs/heads/master@{#434024}

Powered by Google App Engine
This is Rietveld 408576698