Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.h

Issue 2522663005: [Sync] Updated CookieJarMismatch to handle multiple sync cycles during OpenTabAndGetLocalWindows. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sessions_helper.h
diff --git a/chrome/browser/sync/test/integration/sessions_helper.h b/chrome/browser/sync/test/integration/sessions_helper.h
index bfa01297c2ad246bb9c4618517842a01a40555e9..365bc091c121cce1178e8f8c9b133fce46b2e284 100644
--- a/chrome/browser/sync/test/integration/sessions_helper.h
+++ b/chrome/browser/sync/test/integration/sessions_helper.h
@@ -33,7 +33,11 @@ bool GetLocalWindows(int index, ScopedWindowMap* local_windows);
// Creates and verifies the creation of a new window for profile |index| with
// one tab displaying |url|. Copies the SessionWindow associated with the new
-// window to |local_windows|. Returns true if successful.
+// window to |local_windows|. Returns true if successful. This call results in
+// multiple sessions changes, and performs synchronous blocking. It is rare, but
+// possible, that multiple sync cycle commits occur as a result of this call.
+// Test cases should be written to handle this possibility, otherwise they may
+// flake.
bool OpenTabAndGetLocalWindows(int index,
const GURL& url,
ScopedWindowMap* local_windows);
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698