Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2522663003: [Buildfix] Fix enable_webrtc=false build. (Closed)

Created:
4 years, 1 month ago by mbjorge
Modified:
4 years, 1 month ago
Reviewers:
bbudge, Guido Urdaneta
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Buildfix] Fix enable_webrtc=false build. BUG=667527 TEST=ninja content/renderer Committed: https://crrev.com/53189bba54cc9bb057f9e35ede472088bed73a1d Cr-Commit-Position: refs/heads/master@{#433753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/pepper/pepper_media_device_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mbjorge
4 years, 1 month ago (2016-11-21 23:45:56 UTC) #2
mbjorge
4 years, 1 month ago (2016-11-21 23:46:32 UTC) #3
Guido Urdaneta
On 2016/11/21 23:46:32, mbjorge wrote: lgtm
4 years, 1 month ago (2016-11-21 23:50:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522663003/1
4 years, 1 month ago (2016-11-22 00:00:42 UTC) #6
bbudge
lgtm
4 years, 1 month ago (2016-11-22 00:05:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/239110) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-22 00:21:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522663003/1
4 years, 1 month ago (2016-11-22 00:51:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 02:39:50 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:42:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53189bba54cc9bb057f9e35ede472088bed73a1d
Cr-Commit-Position: refs/heads/master@{#433753}

Powered by Google App Engine
This is Rietveld 408576698