Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2522653002: Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
haraken, whywhat, sof
CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, kouhei+heap_chromium.org, loading-reviews+fetch_chromium.org, oilpan-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator (patchset #1 id:1 of https://codereview.chromium.org/2510353005/ ) Reason for revert: Likely cause for blink_heap_unittests and webkit_unit_tests failures. See https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/101018 Original issue's description: > Move ProcessHeap::isLowEndDevice to MemoryCoordinator > > Since this is just moving code around, both me and haraken@ agreed that > it couldn't be the real reason behind the blink_heap_unittests failures. > Hence relanding https://codereview.chromium.org/2503433003 > > BUG=None > TEST=Run the failing tests locally (on Linux) > > Committed: https://crrev.com/a3fa4889e144bcee7491380c0364c46eb9fa4da4 > Cr-Commit-Position: refs/heads/master@{#433613} TBR=haraken@chromium.org,sigbjornf@opera.com,avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/248422552994b04ecf2f62fbf5ba7dca7ad7e2c1 Cr-Commit-Position: refs/heads/master@{#433632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
piman
Created Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator
4 years, 1 month ago (2016-11-21 20:34:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522653002/1
4 years, 1 month ago (2016-11-21 20:35:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 20:37:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/248422552994b04ecf2f62fbf5ba7dca7ad7e2c1 Cr-Commit-Position: refs/heads/master@{#433632}
4 years, 1 month ago (2016-11-21 20:41:51 UTC) #7
sof
thanks, lgtm.
4 years, 1 month ago (2016-11-21 21:07:49 UTC) #8
haraken
4 years, 1 month ago (2016-11-22 00:58:10 UTC) #9
Message was sent while issue was closed.
LGTM to revert, but Sigbjorn's hint (=when MemoryCoordinator::instance() is
called) will be helpful to fix the failure.

Powered by Google App Engine
This is Rietveld 408576698