Issue 2522513002: Update test script short reproduction command to not print --packages flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2522513002: Update test script short reproduction command to not print --packages flag. (Closed)

Created:
4 years, 1 month ago by Bill Hesse

Modified:
4 years, 1 month ago

Reviewers:
eernst

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update test script short reproduction command to not print --packages flag. Also run dartfmt on test_options.dart BUG= R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/3e78c9bd314b7fdae965725d728b8a1488d59502

Patch Set 1 #

Total comments: 1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -45 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		6 chunks	+60 lines, -45 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eernst

LGTM. https://codereview.chromium.org/2522513002/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/2522513002/diff/1/tools/testing/dart/test_options.dart#newcode224 tools/testing/dart/test_options.dart:224: type: 'bool'), Confusing! Just to check that my ...

4 years, 1 month ago (2016-11-21 16:41:50 UTC) #2

Bill Hesse

4 years, 1 month ago (2016-11-21 17:27:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3e78c9bd314b7fdae965725d728b8a1488d59502 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages