Update test script short reproduction command to not print --packages flag.

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "drt_updater.dart";
 import "test_suite.dart";
 import "path.dart";
@@ skipping 65 matching lines @@
 
    dart2app:
    dart2appjit: Compile the Dart code into an app snapshot before running test
           (only valid with dart_app runtime)
 
    dartk: Compile the Dart source into Kernel before running test.
 
    dartkp: Compiler the Dart source into Kernel and then Kernel into AOT
    snapshot before running the test.''',
           ['-c', '--compiler'],
-          ['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app',
-           'dart2appjit', 'dartk', 'dartkp'],
+          [
+            'none',
+            'precompiler',
+            'dart2js',
+            'dart2analyzer',
+            'dart2app',
+            'dart2appjit',
+            'dartk',
+            'dartkp'
+          ],
           'none'),
       // TODO(antonm): fix the option drt.
       new _TestOptionSpecification(
           'runtime',
           '''Where the tests should be run.
     vm: Run Dart code on the standalone dart vm.
 
     dart_precompiled: Run a precompiled snapshot on a variant of the standalone
                       dart vm lacking a JIT.
 
@@ skipping 93 matching lines @@
           'cps_ir',
           'Run the compiler with the cps based backend',
           ['--cps-ir'],
           [],
           false,
           type: 'bool'),
       new _TestOptionSpecification(
           'noopt', 'Run an in-place precompilation', ['--noopt'], [], false,
           type: 'bool'),
       new _TestOptionSpecification(
-          'fast_startup', 'Pass the --fast-startup flag to dart2js',
-          ['--fast-startup'], [], false,
+          'fast_startup',
+          'Pass the --fast-startup flag to dart2js',
+          ['--fast-startup'],
+          [],
+          false,
+          type: 'bool'),
+      new _TestOptionSpecification('hot_reload', 'Run hot reload stress tests',
+          ['--hot-reload'], [], false,
           type: 'bool'),
       new _TestOptionSpecification(
-          'hot_reload', 'Run hot reload stress tests', ['--hot-reload'], [],
-          false, type: 'bool'),
-      new _TestOptionSpecification(
           'hot_reload_rollback',
-          'Run hot reload rollback stress tests', ['--hot-reload-rollback'],
+          'Run hot reload rollback stress tests',
+          ['--hot-reload-rollback'],
           [],
-          false, type: 'bool'),
+          false,
+          type: 'bool'),

[eernst, 2016/11/21 16:41:50]

Confusing! Just to check that my understanding matches your intentions: As far
as I can see, there are no changes (except formatting) to the hot_reload and
hot_reload_rollback specifications, in spite the red and blue colors.

       new _TestOptionSpecification(
           'use_blobs',
           'Use mmap instead of shared libraries for precompilation',
-          ['--use-blobs'], [], false, type: 'bool'),
+          ['--use-blobs'],
+          [],
+          false,
+          type: 'bool'),
       new _TestOptionSpecification(
           'timeout', 'Timeout in seconds', ['-t', '--timeout'], [], -1,
           type: 'int'),
       new _TestOptionSpecification(
           'progress',
           'Progress indication mode',
           ['-p', '--progress'],
           [
             'compact',
             'color',
@@ skipping 378 matching lines @@
     'safari',
     'build_directory',
     'append_logs',
     'local_ip',
     'shard',
     'shards',
   ]);
 
   List<String> _constructReproducingCommandArguments(Map config) {
     var arguments = new List<String>();
-    for (var configKey in config.keys) {
-      if (!_blacklistedOptions.contains(configKey)) {
-        for (var option in _options) {
-          var configValue = config[configKey];
-          // We only include entries of [conf] if we find an option for it.
-          if (configKey == option.name && configValue != option.defaultValue) {
-            var isBooleanOption = option.type == 'bool';
-            // Sort by length, so we get the shortest variant.
-            var possibleOptions = new List.from(option.keys);
-            possibleOptions.sort((a, b) => (a.length < b.length ? -1 : 1));
-            var key = possibleOptions[0];
-            if (key.startsWith('--')) {
-              // long version
-              arguments.add(key);
-              if (!isBooleanOption) {
-                arguments.add("$configValue");
-              }
-            } else {
-              // short version
-              assert(key.startsWith('-'));
-              if (!isBooleanOption) {
-                arguments.add("$key$configValue");
-              } else {
-                arguments.add(key);
-              }
-            }
-          }
-        }
+    for (var option in _options) {
+      var name = option.name;
+      if (!config.containsKey(name) || _blacklistedOptions.contains(name)) {
+        continue;
+      }
+      var value = config[name];
+      if (config[name] == option.defaultValue ||
+          (name == 'packages' &&
+              value ==
+                  TestUtils.dartDirUri.resolve('.packages').toFilePath())) {
+        continue;
+      }
+      shortest(String a, String b) => a.length <= b.length ? a : b;
+      var key = option.keys.reduce(shortest);
+      if (option.type == 'bool') {
+        arguments.add(key);
+      } else if (key.startsWith('--')) {
+        // long version
+        arguments.add(key);
+        arguments.add("$value");
+      } else {
+        // short version
+        assert(key.startsWith('-'));
+        arguments.add("$key$value");
       }
     }
     return arguments;
   }
 
   /**
    * Determine if a particular configuration has a valid combination of compiler
    * and runtime elements.
    */
   bool _isValidConfig(Map config) {
@@ skipping 167 matching lines @@
       }
       configuration['selectors'] = selectorMap;
     }
 
     // Put observatory_ui in a configuration with its own packages override.
     // Only one value in the configuration map is mutable:
     selectors = configuration['selectors'];
     if (selectors.containsKey('observatory_ui')) {
       if (selectors.length == 1) {
         configuration['packages'] = TestUtils.dartDirUri
-          .resolve('runtime/observatory/.packages').toFilePath();
+            .resolve('runtime/observatory/.packages')
+            .toFilePath();
       } else {
         // Make a new configuration whose selectors map only contains
         // observatory_ui, and remove the key from the original selectors.
         // The only mutable value in the map is the selectors, so a
         // shallow copy is safe.
         var observatoryConfiguration = new Map.from(configuration);
-        observatoryConfiguration['selectors'] =
-          {'observatory_ui': selectors['observatory_ui']};
+        observatoryConfiguration['selectors'] = {
+          'observatory_ui': selectors['observatory_ui']
+        };
         selectors.remove('observatory_ui');
 
         // Set the packages flag.
         observatoryConfiguration['packages'] = TestUtils.dartDirUri
-          .resolve('runtime/observatory/.packages').toFilePath();
+            .resolve('runtime/observatory/.packages')
+            .toFilePath();
 
         // Return the expansions of both configurations. Neither will reach
         // this line in the recursive call to _expandConfigurations.
         return _expandConfigurations(configuration)
           ..addAll(_expandConfigurations(observatoryConfiguration));
       }
     }
     // Set the default package spec explicitly.
     if (configuration['package_root'] == null &&
         configuration['packages'] == null) {
       configuration['packages'] =
-        TestUtils.dartDirUri.resolve('.packages').toFilePath();
+          TestUtils.dartDirUri.resolve('.packages').toFilePath();
     }
 
     // Expand the architectures.
     if (configuration['arch'].contains(',')) {
       return _expandHelper('arch', configuration);
     }
 
     // Expand modes.
     if (configuration['mode'].contains(',')) {
       return _expandHelper('mode', configuration);
@@ skipping 11 matching lines @@
     } else {
       // All runtimes eventually go through this path, after expansion.
       var updater = runtimeUpdater(configuration);
       if (updater != null) {
         updater.update();
       }
     }
 
     // Adjust default timeout based on mode, compiler, and sometimes runtime.
     if (configuration['timeout'] == -1) {
-      var isReload = configuration['hot_reload'] ||
-                     configuration['hot_reload_rollback'];
+      var isReload =
+          configuration['hot_reload'] || configuration['hot_reload_rollback'];
       int compilerMulitiplier =
           new CompilerConfiguration(configuration).computeTimeoutMultiplier();
       int runtimeMultiplier = new RuntimeConfiguration(configuration)
           .computeTimeoutMultiplier(
               mode: configuration['mode'],
               isChecked: configuration['checked'],
               isReload: isReload,
               arch: configuration['arch']);
       configuration['timeout'] = 60 * compilerMulitiplier * runtimeMultiplier;
     }
@@ skipping 73 matching lines @@
       if (option.keys.contains(name)) {
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
   List<_TestOptionSpecification> _options;
 }