Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2522453003: invalidateColumnSets() doesn't need to mark anything for layout. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

invalidateColumnSets() doesn't need to mark anything for layout. Committed: https://crrev.com/815d72c20e3dd1c20dd80c7966dd99765ea140e5 Cr-Commit-Position: refs/heads/master@{#433952}

Patch Set 1 #

Patch Set 2 : Rebaseline test expectation. Less layout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/column-rules-fixed-height-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/column-rules-fixed-height-expected.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-22 17:01:00 UTC) #8
eae
LGTM!
4 years, 1 month ago (2016-11-22 17:45:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522453003/20001
4 years, 1 month ago (2016-11-22 19:46:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 20:04:45 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 20:09:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/815d72c20e3dd1c20dd80c7966dd99765ea140e5
Cr-Commit-Position: refs/heads/master@{#433952}

Powered by Google App Engine
This is Rietveld 408576698