Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 2522453003: invalidateColumnSets() doesn't need to mark anything for layout. (Closed)
Patch Set: Rebaseline test expectation. Less layout. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 virtual void addColumnSetToThread(LayoutMultiColumnSet*) = 0; 102 virtual void addColumnSetToThread(LayoutMultiColumnSet*) = 0;
103 virtual void removeColumnSetFromThread(LayoutMultiColumnSet*); 103 virtual void removeColumnSetFromThread(LayoutMultiColumnSet*);
104 104
105 void computeLogicalHeight(LayoutUnit logicalHeight, 105 void computeLogicalHeight(LayoutUnit logicalHeight,
106 LayoutUnit logicalTop, 106 LayoutUnit logicalTop,
107 LogicalExtentComputedValues&) const override; 107 LogicalExtentComputedValues&) const override;
108 108
109 bool hasColumnSets() const { return m_multiColumnSetList.size(); } 109 bool hasColumnSets() const { return m_multiColumnSetList.size(); }
110 110
111 void validateColumnSets(); 111 void validateColumnSets();
112 void invalidateColumnSets(); 112 void invalidateColumnSets() { m_columnSetsInvalidated = true; }
113 bool hasValidColumnSetInfo() const { 113 bool hasValidColumnSetInfo() const {
114 return !m_columnSetsInvalidated && !m_multiColumnSetList.isEmpty(); 114 return !m_columnSetsInvalidated && !m_multiColumnSetList.isEmpty();
115 } 115 }
116 116
117 bool mapToVisualRectInAncestorSpace( 117 bool mapToVisualRectInAncestorSpace(
118 const LayoutBoxModelObject* ancestor, 118 const LayoutBoxModelObject* ancestor,
119 LayoutRect&, 119 LayoutRect&,
120 VisualRectFlags = DefaultVisualRectFlags) const override; 120 VisualRectFlags = DefaultVisualRectFlags) const override;
121 121
122 LayoutUnit pageLogicalHeightForOffset(LayoutUnit); 122 LayoutUnit pageLogicalHeightForOffset(LayoutUnit);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 struct ValueToString<LayoutMultiColumnSet*> { 202 struct ValueToString<LayoutMultiColumnSet*> {
203 static String toString(const LayoutMultiColumnSet* value) { 203 static String toString(const LayoutMultiColumnSet* value) {
204 return String::format("%p", value); 204 return String::format("%p", value);
205 } 205 }
206 }; 206 };
207 #endif 207 #endif
208 208
209 } // namespace blink 209 } // namespace blink
210 210
211 #endif // LayoutFlowThread_h 211 #endif // LayoutFlowThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698