Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2522443002: Remove SVGCursorElement (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years ago
CC:
fs, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, sashab, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGCursorElement This allows significant cleanup of CSSCursorImageValue, so do that too. Intent-thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/r0lnh5Rw23M TBR=timvolodine@chromium.org BUG=650598 Committed: https://crrev.com/f63d67df608751f83eaa15a67df069a38714f171 Cr-Commit-Position: refs/heads/master@{#438116}

Patch Set 1 #

Patch Set 2 : Update expectations and tests #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Update expectations #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -856 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/mouse-cursor.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/mouse-cursor-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt View 1 2 3 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/cursor-change-href.svg View 1 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/cursor-change-href-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/cursor-hotspot-override-from-css.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/svgcursorelement-use-counter.html View 1 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGStaticListTearOff-contextElement-crash.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGStaticListTearOff-contextElement-crash-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js View 1 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js View 1 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js View 1 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js View 1 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCursorImageValue.h View 2 chunks +7 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCursorImageValue.cpp View 1 2 3 4 5 6 3 chunks +5 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp View 4 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 4 5 1 chunk +6 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGCursorElement.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGCursorElement.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGCursorElement.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 2 3 4 5 3 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementRareData.h View 1 2 3 5 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementRareData.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTagNames.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 51 (40 generated)
fs
timvolodine: android_webview/ timloh: CSSCursorImageValue changes timpdr: rest
4 years ago (2016-12-08 21:37:12 UTC) #20
pdr.
On 2016/12/08 at 21:37:12, fs wrote: > timvolodine: android_webview/ > timloh: CSSCursorImageValue changes > timpdr: ...
4 years ago (2016-12-09 05:53:42 UTC) #24
sashab
Wow cool!! This patch: \o/
4 years ago (2016-12-12 02:00:18 UTC) #26
Timothy Loh
On 2016/12/08 21:37:12, fs wrote: > timvolodine: android_webview/ > timloh: CSSCursorImageValue changes > timpdr: rest ...
4 years ago (2016-12-12 02:01:58 UTC) #27
fs
+timfoolip for */webexposed/* (Will TBR timvolodine, since he appears to be OOO.)
4 years ago (2016-12-12 11:56:29 UTC) #29
foolip
*/webexposed/* lgtm
4 years ago (2016-12-12 13:00:06 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522443002/80001
4 years ago (2016-12-12 13:07:22 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121095) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-12 13:09:21 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522443002/120001
4 years ago (2016-12-13 10:13:42 UTC) #46
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-13 10:20:39 UTC) #49
commit-bot: I haz the power
4 years ago (2016-12-13 10:24:00 UTC) #51
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f63d67df608751f83eaa15a67df069a38714f171
Cr-Commit-Position: refs/heads/master@{#438116}

Powered by Google App Engine
This is Rietveld 408576698