[MD Extensions] Add logic for opening the extension's home page

[MD Extensions] Add logic for opening the extension's home page

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0d19dfdc5cfd59900388abe36213244bb64e7292
Cr-Commit-Position: refs/heads/master@{#434854}

[Devlin, 2016-11-23 22:10:59]

Description was changed from

==========
[MD Extensions] Add logic for opening the extension's home page

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
==========

to

==========
[MD Extensions] Add logic for opening the extension's home page

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-11-23 22:18:22]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-11-23 22:18:27]

Patchset #2 (id:20001) has been deleted

[Devlin, 2016-11-23 22:18:36]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-23 22:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-11-23 23:52:34]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-11-23 23:52:35]

Easy one for you, Michael

[commit-bot: I haz the power, 2016-11-24 00:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 00:21:16]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[michaelpg, 2016-11-28 23:09:22]

lgtm

https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_extensions/detail_view.js (right):

https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.js:56: return
this.data.homePage.url.length > 0;
nit: add a comment that we ignore |specified| because [what the CL description
says]

[Devlin, 2016-11-28 23:29:11]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:30:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:56:50]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-29 02:13:02]

https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_extensions/detail_view.js (right):

https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.js:56: return
this.data.homePage.url.length > 0;
On 2016/11/28 23:09:21, michaelpg wrote:
> nit: add a comment that we ignore |specified| because [what the CL description
> says]

Done.

[Devlin, 2016-11-29 02:13:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-11-29 02:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2522303002/#ps60001
(title: "add comment")

[commit-bot: I haz the power, 2016-11-29 02:14:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480385589070280,
"parent_rev": "39945cb0cae942d834b51920b3e5841e14258202", "commit_rev":
"8625a0a73ff1511899d3fcae9f3b0eccdf367d0b"}

[commit-bot: I haz the power, 2016-11-29 03:01:00]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-29 03:04:22]

Description was changed from

==========
[MD Extensions] Add logic for opening the extension's home page

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Add logic for opening the extension's home page

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0d19dfdc5cfd59900388abe36213244bb64e7292
Cr-Commit-Position: refs/heads/master@{#434854}
==========

[commit-bot: I haz the power, 2016-11-29 03:04:23]

Patchset 2 (id:??) landed as
https://crrev.com/0d19dfdc5cfd59900388abe36213244bb64e7292
Cr-Commit-Position: refs/heads/master@{#434854}