Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2522303002: [MD Extensions] Add logic for opening the extension's home page (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Extensions] Add logic for opening the extension's home page The detail view for extensions includes a button to open the extension's home page (which defaults to the webstore page if an extension doens't specify one). Hook this up, and add a test. BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0d19dfdc5cfd59900388abe36213244bb64e7292 Cr-Commit-Position: refs/heads/master@{#434854}

Patch Set 1 : closure #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chrome/browser/resources/md_extensions/detail_view.html View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_extensions/detail_view.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/data/webui/extensions/extension_detail_view_test.js View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/test/data/webui/extensions/extension_test_util.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Devlin
Easy one for you, Michael
4 years ago (2016-11-23 23:52:35 UTC) #7
michaelpg
lgtm https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resources/md_extensions/detail_view.js File chrome/browser/resources/md_extensions/detail_view.js (right): https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resources/md_extensions/detail_view.js#newcode56 chrome/browser/resources/md_extensions/detail_view.js:56: return this.data.homePage.url.length > 0; nit: add a comment ...
4 years ago (2016-11-28 23:09:22 UTC) #10
Devlin
https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resources/md_extensions/detail_view.js File chrome/browser/resources/md_extensions/detail_view.js (right): https://codereview.chromium.org/2522303002/diff/40001/chrome/browser/resources/md_extensions/detail_view.js#newcode56 chrome/browser/resources/md_extensions/detail_view.js:56: return this.data.homePage.url.length > 0; On 2016/11/28 23:09:21, michaelpg wrote: ...
4 years ago (2016-11-29 02:13:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522303002/60001
4 years ago (2016-11-29 02:14:22 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-11-29 03:01:00 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-29 03:04:23 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d19dfdc5cfd59900388abe36213244bb64e7292
Cr-Commit-Position: refs/heads/master@{#434854}

Powered by Google App Engine
This is Rietveld 408576698