Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5081)

Unified Diff: chrome/test/data/webui/extensions/extension_detail_view_test.js

Issue 2522303002: [MD Extensions] Add logic for opening the extension's home page (Closed)
Patch Set: add comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/extensions/extension_detail_view_test.js
diff --git a/chrome/test/data/webui/extensions/extension_detail_view_test.js b/chrome/test/data/webui/extensions/extension_detail_view_test.js
index 741e8d5c31e3dd9b7592ca50ba471042ef6ab1de..7572b4621cf3b9d148d16b6012106a2061bff0e3 100644
--- a/chrome/test/data/webui/extensions/extension_detail_view_test.js
+++ b/chrome/test/data/webui/extensions/extension_detail_view_test.js
@@ -54,7 +54,7 @@ cr.define('extension_detail_view_tests', function() {
var testIsVisible = extension_test_util.isVisible.bind(null, item);
expectTrue(testIsVisible('#close-button'));
- expectTrue(testIsVisible('#open-in-webstore'));
+ expectFalse(testIsVisible('#open-homepage'));
expectFalse(testIsVisible('#options'));
// Check the checkboxes visibility and state. They should be visible
@@ -108,6 +108,11 @@ cr.define('extension_detail_view_tests', function() {
'chrome-extension://' + extensionData.id + '/options.html';
item.set('data.optionsPage', {openInTab: true, url: optionsUrl});
expectTrue(testIsVisible('#options'));
+
+ var homepageUrl = 'https://www.example.com/';
+ item.set('data.homePage', {specified: true, url: homepageUrl});
+ expectTrue(testIsVisible('#open-homepage'));
+ expectEquals(homepageUrl, item.$$('#open-homepage').href);
});
test(assert(TestNames.ClickableElements), function() {
« no previous file with comments | « chrome/browser/resources/md_extensions/detail_view.js ('k') | chrome/test/data/webui/extensions/extension_test_util.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698