Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 25223002: Move core/platform/sql into modules/webdatabase (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, jeez, jamesr
Visibility:
Public.

Description

Move core/platform/sql into modules/webdatabase This code is specific to webdatabase. There isn't any particular reason to move it to blink_platform.dll, which would entail removing dependencies from this code back into the webdatabase module. I've also renamed the folder to sqlite to indiciate that this code is specific to sqlite. I've also removed a few unnessary mentions of the word "Chromium" from various names. BUG=297477 R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158670

Patch Set 1 #

Patch Set 2 : Attempt to fix the mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2251 lines) Patch
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/config.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
D Source/core/platform/sql/SQLValue.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/platform/sql/SQLValue.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/platform/sql/SQLiteAuthorizer.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/platform/sql/SQLiteDatabase.h View 1 chunk +0 lines, -170 lines 0 comments Download
D Source/core/platform/sql/SQLiteDatabase.cpp View 1 chunk +0 lines, -499 lines 0 comments Download
D Source/core/platform/sql/SQLiteFileSystem.h View 1 chunk +0 lines, -117 lines 0 comments Download
D Source/core/platform/sql/SQLiteStatement.h View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/core/platform/sql/SQLiteStatement.cpp View 1 chunk +0 lines, -534 lines 0 comments Download
D Source/core/platform/sql/SQLiteTransaction.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/platform/sql/SQLiteTransaction.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D Source/core/platform/sql/chromium/SQLiteFileSystemChromium.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
D Source/core/platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp View 1 chunk +0 lines, -169 lines 0 comments Download
M Source/modules/modules.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/AbstractSQLTransactionBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLResultSetRowList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLValue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteAuthorizer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteFileSystem.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteStatement.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteStatement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteTransaction.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-09-30 08:07:29 UTC) #1
eseidel
Lgtm On Sep 30, 2013 1:07 AM, <abarth@chromium.org> wrote: > Reviewers: eseidel, > > Description: ...
7 years, 2 months ago (2013-09-30 15:17:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25223002/1
7 years, 2 months ago (2013-09-30 16:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25223002/1
7 years, 2 months ago (2013-09-30 19:23:20 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-30 22:03:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25223002/1
7 years, 2 months ago (2013-09-30 22:35:34 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-30 22:50:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25223002/24001
7 years, 2 months ago (2013-10-01 20:46:28 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 23:29:17 UTC) #9
Message was sent while issue was closed.
Change committed as 158670

Powered by Google App Engine
This is Rietveld 408576698