Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2522283003: s390: introduce DUMY opcode for special use. (Closed)

Created:
4 years ago by john.yan
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: introduce DUMY opcode for special use. BUG= R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com Committed: https://crrev.com/5ae3dccad0272925913f53ea31ac807cf798a56e Cr-Commit-Position: refs/heads/master@{#41238}

Patch Set 1 #

Patch Set 2 : make sure not overwrite opcode field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/s390/assembler-s390.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/s390/constants-s390.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
lgtm
4 years ago (2016-11-23 23:30:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522283003/20001
4 years ago (2016-11-24 01:08:27 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 01:31:10 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-24 01:31:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ae3dccad0272925913f53ea31ac807cf798a56e
Cr-Commit-Position: refs/heads/master@{#41238}

Powered by Google App Engine
This is Rietveld 408576698