Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2522273002: Revert of [Telemetry] Disable system_health.memory_desktop on win10 (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
Reviewers:
eakuefner, fmeawad
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Disable system_health.memory_desktop on win10 (patchset #1 id:1 of https://codereview.chromium.org/2520423005/ ) Reason for revert: System health benchmark should be disabled at story level, not the whole benchmark level (if possible). Original issue's description: > [Telemetry] Disable system_health.memory_desktop on win10 > > It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. > > BUG=667941 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf > Cr-Commit-Position: refs/heads/master@{#434132} TBR=eakuefner@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667941 Committed: https://crrev.com/c1fa4049b9bf140f14ae31b2bd6bdac5b81df4ad Cr-Commit-Position: refs/heads/master@{#434200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/system_health.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of [Telemetry] Disable system_health.memory_desktop on win10
4 years ago (2016-11-23 18:12:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522273002/1
4 years ago (2016-11-23 18:12:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 18:13:44 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-23 18:16:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1fa4049b9bf140f14ae31b2bd6bdac5b81df4ad
Cr-Commit-Position: refs/heads/master@{#434200}

Powered by Google App Engine
This is Rietveld 408576698