Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2522273002: Revert of [Telemetry] Disable system_health.memory_desktop on win10 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.timeline import chrome_trace_config 10 from telemetry.timeline import chrome_trace_config
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 def Name(cls): 109 def Name(cls):
110 return 'system_health.memory_%s' % cls.PLATFORM 110 return 'system_health.memory_%s' % cls.PLATFORM
111 111
112 @classmethod 112 @classmethod
113 def ValueCanBeAddedPredicate(cls, value, is_first_result): 113 def ValueCanBeAddedPredicate(cls, value, is_first_result):
114 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 114 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
115 # is able to cope with the data load generated by TBMv2 metrics. 115 # is able to cope with the data load generated by TBMv2 metrics.
116 return not _IGNORED_STATS_RE.search(value.name) 116 return not _IGNORED_STATS_RE.search(value.name)
117 117
118 118
119 @benchmark.Disabled('win10') # http://crbug.com/667941
120 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark): 119 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
121 """Desktop Chrome Memory System Health Benchmark.""" 120 """Desktop Chrome Memory System Health Benchmark."""
122 PLATFORM = 'desktop' 121 PLATFORM = 'desktop'
123 122
124 @classmethod 123 @classmethod
125 def ShouldDisable(cls, possible_browser): 124 def ShouldDisable(cls, possible_browser):
126 # http://crbug.com/624355 (reference builds). 125 # http://crbug.com/624355 (reference builds).
127 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or 126 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or
128 possible_browser.browser_type == 'reference') 127 possible_browser.browser_type == 'reference')
129 128
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 and load a blank page with multiprocess enabled. 181 and load a blank page with multiprocess enabled.
183 """ 182 """
184 183
185 def SetExtraBrowserOptions(self, options): 184 def SetExtraBrowserOptions(self, options):
186 options.AppendExtraBrowserArgs( 185 options.AppendExtraBrowserArgs(
187 ['--webview-sandboxed-renderer']) 186 ['--webview-sandboxed-renderer'])
188 187
189 @classmethod 188 @classmethod
190 def Name(cls): 189 def Name(cls):
191 return 'system_health.webview_startup_multiprocess' 190 return 'system_health.webview_startup_multiprocess'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698