[OfflinePages] RequestCoordinatorFactory return null for incognito

chrome/browser/android/offline_pages/request_coordinator_factory.cc

Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
index 89cffad81553bbb1a11c38a73f0831772742ff22..5dbe367d028797463a8e3cb3473852555dfc00ea 100644
--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc
+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
@@ -49,6 +49,11 @@ RequestCoordinator* RequestCoordinatorFactory::GetForBrowserContext(
 
 KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
+  if (context->IsOffTheRecord()) {
+    DVLOG(1) << "Can't create RequestCoordinator service for incognito mode";

[fgorski, 2016/11/22 21:43:37]

this change is not what you want. Remove GetBrowserContextToUse, which will use
nullptr in place of offtherecord...

[dougarnett, 2016/11/22 22:01:16]

Ok, I will revisit that. I tried that originally but didn't work because I
hadn't figured out that SavePageLater was still being called with null this
pointer. So I expect it will work as long as we also have check for null
RequestCoordinator pointer.

[dougarnett, 2016/11/22 22:28:06]

Done.

+    return nullptr;
+  }
+
   std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
   std::unique_ptr<OfflinerFactory> prerenderer_offliner(
       new PrerenderingOfflinerFactory(context));