[OfflinePages] RequestCoordinatorFactory return null for incognito

chrome/browser/android/offline_pages/request_coordinator_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
@@ skipping 31 matching lines @@
 
 // static
 RequestCoordinator* RequestCoordinatorFactory::GetForBrowserContext(
     content::BrowserContext* context) {
   return static_cast<RequestCoordinator*>(
       GetInstance()->GetServiceForBrowserContext(context, true));
 }
 
 KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
+  if (context->IsOffTheRecord()) {
+    DVLOG(1) << "Can't create RequestCoordinator service for incognito mode";

[fgorski, 2016/11/22 21:43:37]

this change is not what you want. Remove GetBrowserContextToUse, which will use
nullptr in place of offtherecord...

[dougarnett, 2016/11/22 22:01:16]

Ok, I will revisit that. I tried that originally but didn't work because I
hadn't figured out that SavePageLater was still being called with null this
pointer. So I expect it will work as long as we also have check for null
RequestCoordinator pointer.

[dougarnett, 2016/11/22 22:28:06]

Done.

+    return nullptr;
+  }
+
   std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
   std::unique_ptr<OfflinerFactory> prerenderer_offliner(
       new PrerenderingOfflinerFactory(context));
 
   scoped_refptr<base::SequencedTaskRunner> background_task_runner =
       content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
           content::BrowserThread::GetBlockingPool()->GetSequenceToken());
   Profile* profile = Profile::FromBrowserContext(context);
   base::FilePath queue_store_path =
       profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname);
@@ skipping 12 matching lines @@
       std::move(policy), std::move(prerenderer_offliner), std::move(queue),
       std::move(scheduler), network_quality_estimator);
 
   DownloadNotifyingObserver::CreateAndStartObserving(
       request_coordinator,
       base::MakeUnique<android::OfflinePageNotificationBridge>());
 
   return request_coordinator;
 }
 
 content::BrowserContext* RequestCoordinatorFactory::GetBrowserContextToUse(

[fgorski, 2016/11/22 21:43:37]

this is the code that needs to go.

[dougarnett, 2016/11/22 22:28:05]

Acknowledged.

     content::BrowserContext* context) const {
   // TODO(petewil): Make sure we support incognito properly.
   return context;
 }
 
 }  // namespace offline_pages