Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 2521953002: [css-grid] Ship CSS Grid Layout (Closed)

Created:
2 years, 7 months ago by Manuel Rego
Modified:
2 years, 7 months ago
Reviewers:
tkent, cbiesinger, eae
CC:
blink-reviews, chromium-reviews, jfernandez, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Ship CSS Grid Layout Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hBx1ffTS9CQ/TMTigaDIAgAJ BUG=79180 Committed: https://crrev.com/79bd413143afe5ad68104a3c99b9c04f64fc25ac Cr-Commit-Position: refs/heads/master@{#433853}

Patch Set 1 #

Patch Set 2 : Update test results for virtual/stable/webexposed/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
Manuel Rego
We got 3 LGTM on the intent-to-ship, so it'd be nice to switch the flag ...
2 years, 7 months ago (2016-11-22 11:22:53 UTC) #2
tkent
lgtm
2 years, 7 months ago (2016-11-22 11:44:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521953002/1
2 years, 7 months ago (2016-11-22 11:52:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/336824)
2 years, 7 months ago (2016-11-22 12:46:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521953002/20001
2 years, 7 months ago (2016-11-22 12:58:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years, 7 months ago (2016-11-22 14:10:24 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/79bd413143afe5ad68104a3c99b9c04f64fc25ac Cr-Commit-Position: refs/heads/master@{#433853}
2 years, 7 months ago (2016-11-22 14:13:27 UTC) #17
eae
2 years, 7 months ago (2016-11-22 17:44:30 UTC) #18
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698