Issue 2521863002: [Custom Tab] Fix a crash when getting a screenshot of a tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2521863002: [Custom Tab] Fix a crash when getting a screenshot of a tab (Closed)

Created:
4 years, 1 month ago by Ian Wen

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[Custom Tab] Fix a crash when getting a screenshot of a tab Since the screenshot taking happens 1 second later than onFinishLoad(), there should not be any guarantee of whether the tab is alive or not. BUG=667358 Review-Url: https://codereview.chromium.org/2523593003 Cr-Commit-Position: refs/heads/master@{#433724} (cherry picked from commit 3bb40d3030fd4036c4c081892e17da9f042aaa00) Committed: https://chromium.googlesource.com/chromium/src/+/edfcb4808a77fa7a84dfa72e00fd13fc7673c155

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Ian Wen

4 years, 1 month ago (2016-11-22 01:48:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
edfcb4808a77fa7a84dfa72e00fd13fc7673c155.