Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2523593003: [Custom Tab] Fix a crash when getting a screenshot of a tab (Closed)

Created:
4 years, 1 month ago by Ian Wen
Modified:
4 years, 1 month ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tab] Fix a crash when getting a screenshot of a tab Since the screenshot taking happens 1 second later than onFinishLoad(), there should not be any guarantee of whether the tab is alive or not. BUG=667358 Committed: https://crrev.com/3bb40d3030fd4036c4c081892e17da9f042aaa00 Cr-Commit-Position: refs/heads/master@{#433724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ian Wen
PTAL
4 years, 1 month ago (2016-11-22 00:27:43 UTC) #2
Yusuf
lgtm
4 years, 1 month ago (2016-11-22 00:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523593003/1
4 years, 1 month ago (2016-11-22 00:33:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 01:11:29 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 01:18:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bb40d3030fd4036c4c081892e17da9f042aaa00
Cr-Commit-Position: refs/heads/master@{#433724}

Powered by Google App Engine
This is Rietveld 408576698