Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2521823002: Wires up PointerWatcherEventRouter for views aura-mus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up PointerWatcherEventRouter for views aura-mus This is a copy of the existing one using aura types. Will nuke the existing one when services/ui/public/cpp is no more. BUG=663526 TEST=covered by tests. R=erg@chromium.org Committed: https://crrev.com/8b5f503a5918144bf0d87616d6a01be3d3ccd792 Cr-Commit-Position: refs/heads/master@{#433744}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -5 lines) Patch
M ui/aura/mus/window_tree_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +3 lines, -0 lines 1 comment Download
M ui/views/mus/mus_client.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M ui/views/mus/mus_client.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A ui/views/mus/pointer_watcher_event_router2.h View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/views/mus/pointer_watcher_event_router2.cc View 1 chunk +159 lines, -0 lines 0 comments Download
A ui/views/mus/pointer_watcher_event_router2_unittest.cc View 1 chunk +241 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years ago (2016-11-22 00:37:09 UTC) #2
Elliot Glaysher
lgtm https://codereview.chromium.org/2521823002/diff/20001/ui/views/mus/BUILD.gn File ui/views/mus/BUILD.gn (right): https://codereview.chromium.org/2521823002/diff/20001/ui/views/mus/BUILD.gn#newcode36 ui/views/mus/BUILD.gn:36: "pointer_watcher_event_router2.h", I am full of loathing for this ...
4 years ago (2016-11-22 00:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521823002/20001
4 years ago (2016-11-22 00:57:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-22 02:15:29 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-22 02:20:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b5f503a5918144bf0d87616d6a01be3d3ccd792
Cr-Commit-Position: refs/heads/master@{#433744}

Powered by Google App Engine
This is Rietveld 408576698