PKI library: dNSName constraints starting with dot should match subdomains.

PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
Committed: https://crrev.com/72fdcfac34bb34f7d649b4fd0095a4c338d31aee
Cr-Commit-Position: refs/heads/master@{#434782}

[mattm, 2016-11-22 00:00:15]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 00:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 00:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:22:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mattm, 2016-11-22 00:25:27]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 00:25:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-11-22 01:40:43]

Description was changed from

==========
pki library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
==========

to

==========
PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
==========

[mattm, 2016-11-22 02:50:02]

mattm@chromium.org changed reviewers:
+ eroman@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:08:57]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-11-22 23:34:15]

lgtm

https://codereview.chromium.org/2521813002/diff/20001/net/cert/internal/name_...
File net/cert/internal/name_constraints_unittest.cc (right):

https://codereview.chromium.org/2521813002/diff/20001/net/cert/internal/name_...
net/cert/internal/name_constraints_unittest.cc:197: // A permitted dNSName
constraint of ".bar.com" should only match subdomains
If we don't already, might be good to have a test for ".." too (since we have
logic that strips the trailing dot first).

[mattm, 2016-11-24 00:08:50]

https://codereview.chromium.org/2521813002/diff/20001/net/cert/internal/name_...
File net/cert/internal/name_constraints_unittest.cc (right):

https://codereview.chromium.org/2521813002/diff/20001/net/cert/internal/name_...
net/cert/internal/name_constraints_unittest.cc:197: // A permitted dNSName
constraint of ".bar.com" should only match subdomains
On 2016/11/22 23:34:15, eroman (slow) wrote:
> If we don't already, might be good to have a test for ".." too (since we have
> logic that strips the trailing dot first).

Done.

[mattm, 2016-11-24 00:08:58]

The CQ bit was checked by mattm@chromium.org

[mattm, 2016-11-24 00:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2521813002/#ps40001
(title: "add test of ".." constraint")

[commit-bot: I haz the power, 2016-11-24 00:09:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:11:47]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[mattm, 2016-11-28 21:24:31]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480368271554410,
"parent_rev": "c67f2e433332602278a9641c8ddabc08f81729c4", "commit_rev":
"4b2bfcea62f26f9b866604e13f6b97ec852f8732"}

[commit-bot: I haz the power, 2016-11-28 23:55:02]

Description was changed from

==========
PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
==========

to

==========
PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
==========

[commit-bot: I haz the power, 2016-11-28 23:55:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 23:56:50]

Description was changed from

==========
PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574
==========

to

==========
PKI library: dNSName constraints starting with dot should match subdomains.

(Harmonizes under-specified behavior with other platforms.)

BUG=410574

Committed: https://crrev.com/72fdcfac34bb34f7d649b4fd0095a4c338d31aee
Cr-Commit-Position: refs/heads/master@{#434782}
==========

[commit-bot: I haz the power, 2016-11-28 23:56:51]

Patchset 3 (id:??) landed as
https://crrev.com/72fdcfac34bb34f7d649b4fd0095a4c338d31aee
Cr-Commit-Position: refs/heads/master@{#434782}