Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(98)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: net/data/name_constraints_unittest/dnsname-permitted_two_dot.pem
Issue
2521813002
:
PKI library: dNSName constraints starting with dot should match subdomains. (Closed)
Patch Set: add test of ".." constraint
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
net/cert/internal/name_constraints.cc
net/cert/internal/name_constraints_unittest.cc
net/data/name_constraints_unittest/dnsname-excluded_with_leading_dot.pem
net/data/name_constraints_unittest/dnsname-permitted_two_dot.pem
net/data/name_constraints_unittest/generate_name_constraints.py
net/net.gypi
View unified diff
|
Download patch
« no previous file with comments
|
« net/data/name_constraints_unittest/dnsname-excluded_with_leading_dot.pem
('k') |
net/data/name_constraints_unittest/generate_name_constraints.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
0:d=0 hl=2 l= 8 cons: SEQUENCE
2
2:d=1 hl=2 l= 6 cons: cont [ 0 ]
3
4:d=2 hl=2 l= 4 cons: SEQUENCE
4
6:d=3 hl=2 l= 2 prim: cont [ 2 ]
5
-----BEGIN NAME CONSTRAINTS-----
6
MAigBjAEggIuLg==
7
-----END NAME CONSTRAINTS-----
OLD
NEW
« no previous file with comments
|
« net/data/name_constraints_unittest/dnsname-excluded_with_leading_dot.pem
('k') |
net/data/name_constraints_unittest/generate_name_constraints.py »
('j') |
no next file with comments »
Issue 2521813002: PKI library: dNSName constraints starting with dot should match subdomains. (Closed)
Created 4 years ago by mattm
Modified 4 years ago
Reviewers: eroman
Base URL:
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 2521813002:
PKI library: dNSName constraints starting with dot should match subdomains. (Closed)
