components/offline_pages/content/background_loader/background_loader_contents.h - Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/content/background_loader/background_loader_contents.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)

Patch Set: Fix android compile. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser.cc ('k') | components/offline_pages/content/background_loader/background_loader_contents.cc » ('j') | content/public/browser/web_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/content/background_loader/background_loader_contents.h

diff --git a/components/offline_pages/content/background_loader/background_loader_contents.h b/components/offline_pages/content/background_loader/background_loader_contents.h

index 401083ff418453a5fe107fdf9aa716f0a90faab3..2432c84d1921aa50ade28a29fe6a1ab21c1b46b9 100644

--- a/components/offline_pages/content/background_loader/background_loader_contents.h

+++ b/components/offline_pages/content/background_loader/background_loader_contents.h

@@ -44,11 +44,13 @@ class BackgroundLoaderContents : public content::WebContentsDelegate {

const base::Callback<void(bool)>& callback) override;

bool ShouldCreateWebContents(

- content::WebContents* contents,

+ content::WebContents* web_contents,

+ content::SiteInstance* source_site_instance,

int32_t route_id,

int32_t main_frame_route_id,

int32_t main_frame_widget_route_id,

WindowContainerType window_container_type,

+ const GURL& opener_url,

const std::string& frame_name,

const GURL& target_url,

const std::string& partition_id,