Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1679)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Fix android compile. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 2beb83c3b721b8fc03adbb5015f0825567fbc699..2b86ccfe9153f6e8784e7dbdf40791b6254d4eb9 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -42,7 +42,9 @@ class ColorChooser;
class JavaScriptDialogManager;
class PageState;
class RenderFrameHost;
+class RenderWidgetHost;
class SessionStorageNamespace;
+class SiteInstance;
class WebContents;
class WebContentsImpl;
struct ColorSuggestion;
@@ -69,7 +71,6 @@ class WebGestureEvent;
}
namespace content {
-class RenderWidgetHost;
struct OpenURLParams;
struct WebContentsUnresponsiveState;
@@ -296,10 +297,12 @@ class CONTENT_EXPORT WebContentsDelegate {
// be destroyed.
virtual bool ShouldCreateWebContents(
WebContents* web_contents,
+ SiteInstance* source_site_instance,
Charlie Reis 2016/11/23 06:59:48 Maybe also something in the comment about how web_
ncarter (slow) 2016/11/24 00:00:05 Done.
int32_t route_id,
int32_t main_frame_route_id,
int32_t main_frame_widget_route_id,
WindowContainerType window_container_type,
+ const GURL& opener_url,
const std::string& frame_name,
const GURL& target_url,
const std::string& partition_id,

Powered by Google App Engine
This is Rietveld 408576698