Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2521793002:
Allow video_decode_accelerator_unittest to be run in an isolate. (Closed)
|
Created:
4 years, 1 month ago by jbauman Modified:
4 years ago Reviewers:
Pawel Osciak CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow video_decode_accelerator_unittest to be run in an isolate.
The main change is to use base::LaunchUnitTestsSerially as a test runner
so it can parse some command-line arguments the isolate test runner
passes in.
BUG=663126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/483691c8c1de73ba6bc9ffac4f7b311c87a42c23
Cr-Commit-Position: refs/heads/master@{#438779}
Patch Set 1 #
Total comments: 2
Patch Set 2 : disable thumbnail test completely #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 ========== to ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
jbauman@chromium.org changed reviewers: + posciak@chromium.org
Friendly ping.
Sorry for the delay. I also did a quick sanity test run on CrOS ARM. https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... File media/gpu/video_decode_accelerator_unittest.cc (left): https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... media/gpu/video_decode_accelerator_unittest.cc:1783: LOG(FATAL) << "Unexpected switch: " << it->first << ":" << it->second; Could we keep this? https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... File media/gpu/video_decode_accelerator_unittest.cc (right): https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... media/gpu/video_decode_accelerator_unittest.cc:1375: if (render_as_thumbnails) Should we perhaps disable VideoDecodeAcceleratorParamTest.Thumbnail.* for OS_WIN instead at l.1665?
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/06 09:45:00, Pawel Osciak wrote: > Sorry for the delay. I also did a quick sanity test run on CrOS ARM. > > https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... > File media/gpu/video_decode_accelerator_unittest.cc (left): > > https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... > media/gpu/video_decode_accelerator_unittest.cc:1783: LOG(FATAL) << "Unexpected > switch: " << it->first << ":" << it->second; > Could we keep this? Unfortunately the unit test runner doesn't remove the arguments that it understands (like --test-launcher-summary-output, which is passed from the isolate runner). So this would crash on all of those. > > https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... > File media/gpu/video_decode_accelerator_unittest.cc (right): > > https://codereview.chromium.org/2521793002/diff/1/media/gpu/video_decode_acce... > media/gpu/video_decode_accelerator_unittest.cc:1375: if (render_as_thumbnails) > Should we perhaps disable VideoDecodeAcceleratorParamTest.Thumbnail.* for OS_WIN > instead at l.1665? Ok, done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
lgtm
The CQ bit was checked by jbauman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481782608853860,
"parent_rev": "8e784f8f16e682d80567227268fd8f5d674121d6", "commit_rev":
"105524a0b2a5c6d2563928dfab228f3fee2b6e5d"}
Message was sent while issue was closed.
Description was changed from ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2521793002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2521793002 ========== to ========== Allow video_decode_accelerator_unittest to be run in an isolate. The main change is to use base::LaunchUnitTestsSerially as a test runner so it can parse some command-line arguments the isolate test runner passes in. BUG=663126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/483691c8c1de73ba6bc9ffac4f7b311c87a42c23 Cr-Commit-Position: refs/heads/master@{#438779} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/483691c8c1de73ba6bc9ffac4f7b311c87a42c23 Cr-Commit-Position: refs/heads/master@{#438779} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
