Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: storage/browser/blob/blob_storage_context.cc

Issue 2521723008: [BlobStorage] Fix UMA reporting. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/blob/blob_storage_context.cc
diff --git a/storage/browser/blob/blob_storage_context.cc b/storage/browser/blob/blob_storage_context.cc
index 01faea71033edc314ae19711cfcfadda00bbf6aa..1fecda89f5b6799136cab3bc4089840251ad8f3b 100644
--- a/storage/browser/blob/blob_storage_context.cc
+++ b/storage/browser/blob/blob_storage_context.cc
@@ -297,8 +297,6 @@ BlobStorageContext::BlobSlice::BlobSlice(const BlobEntry& source,
source_item->expected_modification_time());
data_item =
new BlobDataItem(std::move(element), source_item->data_handle_);
- UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.Bytes",
- read_size / 1024);
DCHECK(!BlobDataBuilder::IsFutureFileItem(source_item->data_element()))
<< "File allocation unimplemented.";
@@ -315,6 +313,8 @@ BlobStorageContext::BlobSlice::BlobSlice(const BlobEntry& source,
break;
}
case DataElement::TYPE_DISK_CACHE_ENTRY: {
+ UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.CacheEntry",
+ read_size / 1024);
std::unique_ptr<DataElement> element(new DataElement());
element->SetToDiskCacheEntryRange(source_item->offset() + item_offset,
read_size);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698