Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: storage/browser/blob/blob_storage_context.cc

Issue 2521723008: [BlobStorage] Fix UMA reporting. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/blob/blob_storage_context.h" 5 #include "storage/browser/blob/blob_storage_context.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 } 290 }
291 case DataElement::TYPE_FILE: { 291 case DataElement::TYPE_FILE: {
292 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.File", 292 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.File",
293 read_size / 1024); 293 read_size / 1024);
294 std::unique_ptr<DataElement> element(new DataElement()); 294 std::unique_ptr<DataElement> element(new DataElement());
295 element->SetToFilePathRange( 295 element->SetToFilePathRange(
296 source_item->path(), source_item->offset() + item_offset, read_size, 296 source_item->path(), source_item->offset() + item_offset, read_size,
297 source_item->expected_modification_time()); 297 source_item->expected_modification_time());
298 data_item = 298 data_item =
299 new BlobDataItem(std::move(element), source_item->data_handle_); 299 new BlobDataItem(std::move(element), source_item->data_handle_);
300 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.Bytes",
301 read_size / 1024);
302 300
303 DCHECK(!BlobDataBuilder::IsFutureFileItem(source_item->data_element())) 301 DCHECK(!BlobDataBuilder::IsFutureFileItem(source_item->data_element()))
304 << "File allocation unimplemented."; 302 << "File allocation unimplemented.";
305 break; 303 break;
306 } 304 }
307 case DataElement::TYPE_FILE_FILESYSTEM: { 305 case DataElement::TYPE_FILE_FILESYSTEM: {
308 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.FileSystem", 306 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.FileSystem",
309 read_size / 1024); 307 read_size / 1024);
310 std::unique_ptr<DataElement> element(new DataElement()); 308 std::unique_ptr<DataElement> element(new DataElement());
311 element->SetToFileSystemUrlRange( 309 element->SetToFileSystemUrlRange(
312 source_item->filesystem_url(), source_item->offset() + item_offset, 310 source_item->filesystem_url(), source_item->offset() + item_offset,
313 read_size, source_item->expected_modification_time()); 311 read_size, source_item->expected_modification_time());
314 data_item = new BlobDataItem(std::move(element)); 312 data_item = new BlobDataItem(std::move(element));
315 break; 313 break;
316 } 314 }
317 case DataElement::TYPE_DISK_CACHE_ENTRY: { 315 case DataElement::TYPE_DISK_CACHE_ENTRY: {
316 UMA_HISTOGRAM_COUNTS("Storage.BlobItemSize.BlobSlice.CacheEntry",
317 read_size / 1024);
318 std::unique_ptr<DataElement> element(new DataElement()); 318 std::unique_ptr<DataElement> element(new DataElement());
319 element->SetToDiskCacheEntryRange(source_item->offset() + item_offset, 319 element->SetToDiskCacheEntryRange(source_item->offset() + item_offset,
320 read_size); 320 read_size);
321 data_item = 321 data_item =
322 new BlobDataItem(std::move(element), source_item->data_handle_, 322 new BlobDataItem(std::move(element), source_item->data_handle_,
323 source_item->disk_cache_entry(), 323 source_item->disk_cache_entry(),
324 source_item->disk_cache_stream_index(), 324 source_item->disk_cache_stream_index(),
325 source_item->disk_cache_side_stream_index()); 325 source_item->disk_cache_side_stream_index());
326 break; 326 break;
327 } 327 }
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 if (building_state->memory_quota_request) { 721 if (building_state->memory_quota_request) {
722 building_state->memory_quota_request->Cancel(); 722 building_state->memory_quota_request->Cancel();
723 } 723 }
724 } 724 }
725 entry->ClearItems(); 725 entry->ClearItems();
726 entry->ClearOffsets(); 726 entry->ClearOffsets();
727 entry->set_size(0); 727 entry->set_size(0);
728 } 728 }
729 729
730 } // namespace storage 730 } // namespace storage
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698