Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: net/quic/chromium/quic_chromium_client_session.h

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session.h
diff --git a/net/quic/chromium/quic_chromium_client_session.h b/net/quic/chromium/quic_chromium_client_session.h
index 04eeda4a4b304b6e5d944e8f0844a745db106fd4..3c2b94d41a0247bd15a987cdbba21f3d6ba30691 100644
--- a/net/quic/chromium/quic_chromium_client_session.h
+++ b/net/quic/chromium/quic_chromium_client_session.h
@@ -131,6 +131,7 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
base::TimeTicks dns_resolution_start_time,
base::TimeTicks dns_resolution_end_time,
QuicClientPushPromiseIndex* push_promise_index,
+ ServerPushDelegate* push_delegate,
Ryan Hamilton 2016/11/23 20:43:30 Should this method DCHECK that push_delegate is no
Zhongyi Shi 2016/11/23 23:53:49 Nope. The push_delegate will be null if we don't e
base::TaskRunner* task_runner,
std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,
NetLog* net_log);
@@ -307,10 +308,6 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
void OnPushStreamTimedOut(QuicStreamId stream_id) override;
- void set_push_delegate(ServerPushDelegate* push_delegate) {
- push_delegate_ = push_delegate;
- }
-
// Cancels the push if the push stream for |url| has not been claimed and is
// still active. Otherwise, no-op.
void CancelPush(const GURL& url);

Powered by Google App Engine
This is Rietveld 408576698