net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc - Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

diff --git a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

index 4175907c29632c18190870fad2eb61773931cf5f..e433c472bbb983dd40f94461917e74c7be086f57 100644

--- a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

+++ b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

@@ -439,7 +439,7 @@ class BidirectionalStreamQuicImplTest

kQuicYieldAfterPacketsRead,

QuicTime::Delta::FromMilliseconds(kQuicYieldAfterDurationMilliseconds),

/*cert_verify_flags=*/0, DefaultQuicConfig(), &crypto_config_,

- "CONNECTION_UNKNOWN", dns_start, dns_end, &push_promise_index_,

+ "CONNECTION_UNKNOWN", dns_start, dns_end, &push_promise_index_, nullptr,

base::ThreadTaskRunnerHandle::Get().get(),

/*socket_performance_watcher=*/nullptr, net_log().bound().net_log()));

session_->Initialize();