Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2521573002: Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes (patchset #4 i… (Closed)

Created:
4 years, 1 month ago by Manuel Rego
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes (patchset #4 id:60001 of https://codereview.chromium.org/2287533002/ ) Reason for revert: Caused crash on Mac. See http://crbug.com/662016 We're reverting only the code change as we want to keep the tests, that will be fixed after the refactoring happening in bug #627812 is done. So, we need to mark 2 tests as failure in TestExpectations file. BUG=662016, 666688, 627812 Original issue's description: > [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes > > After crrev.com/414446 we can safely remove the temporary fix > (crrev.com/405529) we had to avoid crashes and recursive calls when > computing the auto repeat tracks count for grids with intrinsic sizes. > > This change unveiled a couple of bugs in the computation of auto repeat > tracks for intrinsic sizes. The first one is that we were not considering the > existence of definite minimum sizes. In those cases, instead of just returning 1 > repetition, we should return the minimum number of repetitions that fulfill the > minimum size requirement. > > The second bug was that grids were not properly recomputing the number of > auto repeat tracks when the min|max-content contributions of grid items > changed (whenever the grid container had an intrinsic width). > > One Mozilla test had to be updated too because it was wrong. > BUG=621517, 633474 > > Review-Url: https://codereview.chromium.org/2287533002 > Cr-Commit-Position: refs/heads/master@{#425958} Review-Url: https://codereview.chromium.org/2510393002 Cr-Commit-Position: refs/heads/master@{#433183} (cherry picked from commit b9e7d1d1cc0bcef66b23b320d5c645c97bf4fc64) Committed: https://chromium.googlesource.com/chromium/src/+/ab661a19616ff4cd7ff522cef71354971c4d5694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 4 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Manuel Rego
4 years, 1 month ago (2016-11-21 11:42:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab661a19616ff4cd7ff522cef71354971c4d5694.

Powered by Google App Engine
This is Rietveld 408576698