Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes (patchset #4 i…

Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes (patchset #4 id:60001 of https://codereview.chromium.org/2287533002/ )

Reason for revert: Caused crash on Mac. See http://crbug.com/662016

We're reverting only the code change as we want to keep the tests,
that will be fixed after the refactoring happening in bug #627812
is done.
So, we need to mark 2 tests as failure in TestExpectations file.

BUG=662016, 666688, 627812
Original issue's description:
> [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes
>
> After crrev.com/414446 we can safely remove the temporary fix
> (crrev.com/405529) we had to avoid crashes and recursive calls when
> computing the auto repeat tracks count for grids with intrinsic sizes.
>
> This change unveiled a couple of bugs in the computation of auto repeat
> tracks for intrinsic sizes. The first one is that we were not considering the
> existence of definite minimum sizes. In those cases, instead of just returning 1
> repetition, we should return the minimum number of repetitions that fulfill the
> minimum size requirement.
>
> The second bug was that grids were not properly recomputing the number of
> auto repeat tracks when the min|max-content contributions of grid items
> changed (whenever the grid container had an intrinsic width).
>
> One Mozilla test had to be updated too because it was wrong.
> BUG=621517, 633474
>
> Review-Url: https://codereview.chromium.org/2287533002
> Cr-Commit-Position: refs/heads/master@{#425958}

Committed: https://crrev.com/b9e7d1d1cc0bcef66b23b320d5c645c97bf4fc64
Cr-Commit-Position: refs/heads/master@{#433183}

[Manuel Rego, 2016-11-18 10:56:13]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[jfernandez, 2016-11-18 10:58:49]

lgtm

[Manuel Rego, 2016-11-18 11:00:16]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-11-18 11:00:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 12:32:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-18 12:34:21]

Description was changed from

==========
Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic
sizes (patchset #4 id:60001 of https://codereview.chromium.org/2287533002/ )

Reason for revert: Caused crash on Mac. See http://crbug.com/662016

We're reverting only the code change as we want to keep the tests,
that will be fixed after the refactoring happening in bug #627812
is done.
So, we need to mark 2 tests as failure in TestExpectations file.

BUG=662016,666688,627812

Original issue's description:
> [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes
>
> After crrev.com/414446 we can safely remove the temporary fix
> (crrev.com/405529) we had to avoid crashes and recursive calls when
> computing the auto repeat tracks count for grids with intrinsic sizes.
>
> This change unveiled a couple of bugs in the computation of auto repeat
> tracks for intrinsic sizes. The first one is that we were not considering the
> existence of definite minimum sizes. In those cases, instead of just returning
1
> repetition, we should return the minimum number of repetitions that fulfill
the
> minimum size requirement.
>
> The second bug was that grids were not properly recomputing the number of
> auto repeat tracks when the min|max-content contributions of grid items
> changed (whenever the grid container had an intrinsic width).
>
> One Mozilla test had to be updated too because it was wrong.
> BUG=621517,633474
>
> Review-Url: https://codereview.chromium.org/2287533002
> Cr-Commit-Position: refs/heads/master@{#425958}
==========

to

==========
Revert of [css-grid] Remove a duplicated auto repeat computation for intrinsic
sizes (patchset #4 id:60001 of https://codereview.chromium.org/2287533002/ )

Reason for revert: Caused crash on Mac. See http://crbug.com/662016

We're reverting only the code change as we want to keep the tests,
that will be fixed after the refactoring happening in bug #627812
is done.
So, we need to mark 2 tests as failure in TestExpectations file.

BUG=662016,666688,627812

Original issue's description:
> [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes
>
> After crrev.com/414446 we can safely remove the temporary fix
> (crrev.com/405529) we had to avoid crashes and recursive calls when
> computing the auto repeat tracks count for grids with intrinsic sizes.
>
> This change unveiled a couple of bugs in the computation of auto repeat
> tracks for intrinsic sizes. The first one is that we were not considering the
> existence of definite minimum sizes. In those cases, instead of just returning
1
> repetition, we should return the minimum number of repetitions that fulfill
the
> minimum size requirement.
>
> The second bug was that grids were not properly recomputing the number of
> auto repeat tracks when the min|max-content contributions of grid items
> changed (whenever the grid container had an intrinsic width).
>
> One Mozilla test had to be updated too because it was wrong.
> BUG=621517,633474
>
> Review-Url: https://codereview.chromium.org/2287533002
> Cr-Commit-Position: refs/heads/master@{#425958}

Committed: https://crrev.com/b9e7d1d1cc0bcef66b23b320d5c645c97bf4fc64
Cr-Commit-Position: refs/heads/master@{#433183}
==========

[commit-bot: I haz the power, 2016-11-18 12:34:22]

Patchset 1 (id:??) landed as
https://crrev.com/b9e7d1d1cc0bcef66b23b320d5c645c97bf4fc64
Cr-Commit-Position: refs/heads/master@{#433183}