Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2521463002: Changed EBoxDirection to an enum class and renamed its members to keywords (Closed)

Created:
4 years, 1 month ago by sashab
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed EBoxDirection to an enum class and renamed its members to keywords Changed EBoxDirection to an enum class and gave it an unsigned underlying type. Also renamed its members to match its keywords from CSSValueKeywords.in. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move EBoxDirection to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/0385165cc191fe42f960c852357744ca1ecae1f0 Cr-Commit-Position: refs/heads/master@{#433786}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
sashab
4 years, 1 month ago (2016-11-21 03:29:54 UTC) #2
slangley
lgtm lgtm
4 years, 1 month ago (2016-11-21 03:46:09 UTC) #5
sashab
alancutter@ to RS since slangley is not committer :)
4 years, 1 month ago (2016-11-21 03:47:12 UTC) #7
alancutter (OOO until 2018)
lgtm
4 years, 1 month ago (2016-11-21 04:08:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521463002/1
4 years, 1 month ago (2016-11-21 04:23:38 UTC) #11
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/style/ComputedStyle.h: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-21 05:07:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521463002/20001
4 years, 1 month ago (2016-11-21 05:12:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/110536) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-21 05:14:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521463002/40001
4 years, 1 month ago (2016-11-22 02:45:05 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-22 04:19:14 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 04:20:59 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0385165cc191fe42f960c852357744ca1ecae1f0
Cr-Commit-Position: refs/heads/master@{#433786}

Powered by Google App Engine
This is Rietveld 408576698