Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2521463002: Changed EBoxDirection to an enum class and renamed its members to keywords (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 } 833 }
834 834
835 ASSERT_NOT_REACHED(); 835 ASSERT_NOT_REACHED();
836 return BoxSizingBorderBox; 836 return BoxSizingBorderBox;
837 } 837 }
838 838
839 template <> 839 template <>
840 inline CSSIdentifierValue::CSSIdentifierValue(EBoxDirection e) 840 inline CSSIdentifierValue::CSSIdentifierValue(EBoxDirection e)
841 : CSSValue(IdentifierClass) { 841 : CSSValue(IdentifierClass) {
842 switch (e) { 842 switch (e) {
843 case BNORMAL: 843 case EBoxDirection::Normal:
844 m_valueID = CSSValueNormal; 844 m_valueID = CSSValueNormal;
845 break; 845 break;
846 case BREVERSE: 846 case EBoxDirection::Reverse:
847 m_valueID = CSSValueReverse; 847 m_valueID = CSSValueReverse;
848 break; 848 break;
849 } 849 }
850 } 850 }
851 851
852 template <> 852 template <>
853 inline EBoxDirection CSSIdentifierValue::convertTo() const { 853 inline EBoxDirection CSSIdentifierValue::convertTo() const {
854 switch (m_valueID) { 854 switch (m_valueID) {
855 case CSSValueNormal: 855 case CSSValueNormal:
856 return BNORMAL; 856 return EBoxDirection::Normal;
857 case CSSValueReverse: 857 case CSSValueReverse:
858 return BREVERSE; 858 return EBoxDirection::Reverse;
859 default: 859 default:
860 break; 860 break;
861 } 861 }
862 862
863 ASSERT_NOT_REACHED(); 863 ASSERT_NOT_REACHED();
864 return BNORMAL; 864 return EBoxDirection::Normal;
865 } 865 }
866 866
867 template <> 867 template <>
868 inline CSSIdentifierValue::CSSIdentifierValue(EBoxLines e) 868 inline CSSIdentifierValue::CSSIdentifierValue(EBoxLines e)
869 : CSSValue(IdentifierClass) { 869 : CSSValue(IdentifierClass) {
870 switch (e) { 870 switch (e) {
871 case SINGLE: 871 case SINGLE:
872 m_valueID = CSSValueSingle; 872 m_valueID = CSSValueSingle;
873 break; 873 break;
874 case MULTIPLE: 874 case MULTIPLE:
(...skipping 3869 matching lines...) Expand 10 before | Expand all | Expand 10 after
4744 default: 4744 default:
4745 break; 4745 break;
4746 } 4746 }
4747 ASSERT_NOT_REACHED(); 4747 ASSERT_NOT_REACHED();
4748 return ContainsNone; 4748 return ContainsNone;
4749 } 4749 }
4750 4750
4751 } // namespace blink 4751 } // namespace blink
4752 4752
4753 #endif 4753 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698