Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2521413002: Revert "Implement rewind: drop one or more frames from the debugger." (Closed)

Created:
4 years, 1 month ago by turnidge
Modified:
4 years, 1 month ago
Reviewers:
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Implement rewind: drop one or more frames from the debugger." This reverts commit af1875be910a24f34f1983b314f45c1ecd8097ad. BUG= Committed: https://github.com/dart-lang/sdk/commit/193ddba4dbabd983b7e9ad8bdf2f7c9d976fbf9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -1000 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 11 chunks +29 lines, -95 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +3 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/pause_idle_isolate_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
D runtime/observatory/tests/service/rewind_optimized_out_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D runtime/observatory/tests/service/rewind_test.dart View 1 chunk +0 lines, -173 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/set_vm_name_rpc_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/observatory/tests/service/step_over_await_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 14 chunks +56 lines, -31 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.h View 6 chunks +7 lines, -33 lines 0 comments Download
M runtime/vm/debugger.cc View 13 chunks +18 lines, -305 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/runtime_entry_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 2 chunks +24 lines, -50 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +5 lines, -28 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +5 lines, -28 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 4 chunks +5 lines, -22 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +5 lines, -28 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +5 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
turnidge
4 years, 1 month ago (2016-11-23 00:05:31 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
193ddba4dbabd983b7e9ad8bdf2f7c9d976fbf9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698