Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2521413002: Revert "Implement rewind: drop one or more frames from the debugger." (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_dbc.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index ce6521d339ddb381173946cb60d402c2210b8d9d..ca70617824bf92fbfc39004256c45e44bdd276ba 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -351,6 +351,8 @@ static void PushArgumentsArray(Assembler* assembler) {
// +------------------+
// | return-address | (deoptimization point)
// +------------------+
+// | Saved CODE_REG |
+// +------------------+
// | ... | <- SP of optimized frame
//
// Parts of the code cannot GC, part of the code can GC.
@@ -460,16 +462,15 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
__ popl(ECX); // Pop return address.
__ addl(ESP, EBX); // Remove materialization arguments.
__ pushl(ECX); // Push return address.
- // The caller is responsible for emitting the return instruction.
+ __ ret();
}
// EAX: result, must be preserved
void StubCode::GenerateDeoptimizeLazyFromReturnStub(Assembler* assembler) {
// Return address for "call" to deopt stub.
- __ pushl(Immediate(kZapReturnAddress));
+ __ pushl(Immediate(0xe1e1e1e1));
GenerateDeoptimizationSequence(assembler, kLazyDeoptFromReturn);
- __ ret();
}
@@ -477,15 +478,13 @@ void StubCode::GenerateDeoptimizeLazyFromReturnStub(Assembler* assembler) {
// EDX: stacktrace, must be preserved
void StubCode::GenerateDeoptimizeLazyFromThrowStub(Assembler* assembler) {
// Return address for "call" to deopt stub.
- __ pushl(Immediate(kZapReturnAddress));
+ __ pushl(Immediate(0xe1e1e1e1));
GenerateDeoptimizationSequence(assembler, kLazyDeoptFromThrow);
- __ ret();
}
void StubCode::GenerateDeoptimizeStub(Assembler* assembler) {
GenerateDeoptimizationSequence(assembler, kEagerDeopt);
- __ ret();
}
@@ -1836,22 +1835,6 @@ void StubCode::GenerateRunExceptionHandlerStub(Assembler* assembler) {
}
-// Deoptimize a frame on the call stack before rewinding.
-// The arguments are stored in the Thread object.
-// No result.
-void StubCode::GenerateDeoptForRewindStub(Assembler* assembler) {
- // Push the deopt pc.
- __ pushl(Address(THR, Thread::resume_pc_offset()));
- GenerateDeoptimizationSequence(assembler, kEagerDeopt);
-
- // After we have deoptimized, jump to the correct frame.
- __ EnterStubFrame();
- __ CallRuntime(kRewindPostDeoptRuntimeEntry, 0);
- __ LeaveFrame();
- __ int3();
-}
-
-
// Calls to the runtime to optimize the given function.
// EBX: function to be reoptimized.
// EDX: argument descriptor (preserved).
« no previous file with comments | « runtime/vm/stub_code_dbc.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698