Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2521353005: [OfflinePages] Call NotifyInterrupted for pending requests (Closed)
Patch Set: Fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/downloads/download_notifying_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 8dcc4d94def87f3cd13e2d2d56eefe69908e5153..b5f40489ddf4a4d3c5ed59da0b00a32e93c9445e 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -431,6 +431,7 @@ void RequestCoordinator::AddRequestResultCallback(
AddRequestResult result,
const SavePageRequest& request) {
NotifyAdded(request);
+ NotifyChanged(request);
Pete Williamson 2016/11/28 18:12:03 Did you test this in the running app as opposed to
dougarnett 2016/11/28 18:36:54 Yeah, actually added this due to behavior seen in
fgorski 2016/11/28 20:53:49 Why both added and changed? I don't understand it.
dougarnett 2016/11/28 21:24:55 Dropped this and fixed request state handling in O
// Inform the scheduler that we have an outstanding task.
scheduler_->Schedule(GetTriggerConditions(kUserRequest));
« no previous file with comments | « no previous file | components/offline_pages/downloads/download_notifying_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698