[OfflinePages] Call NotifyInterrupted for pending requests

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <limits>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 413 matching lines @@
     return test_connection_type_;
 
   return net::NetworkChangeNotifier::GetConnectionType();
 }
 
 void RequestCoordinator::AddRequestResultCallback(
     RequestAvailability availability,
     AddRequestResult result,
     const SavePageRequest& request) {
   NotifyAdded(request);
+  NotifyChanged(request);

[Pete Williamson, 2016/11/28 18:12:03]

Did you test this in the running app as opposed to just unit tests?  I'm
concerned that the code may not expect a NotifyChange when a request first gets
added in addition to a NotifyAdded, and want to make sure it doesn't cause any
problems.

[dougarnett, 2016/11/28 18:36:54]

Yeah, actually added this due to behavior seen in app testing.

[fgorski, 2016/11/28 20:53:49]

Why both added and changed? I don't understand it.

[dougarnett, 2016/11/28 21:24:55]

Dropped this and fixed request state handling in OnAdded

   // Inform the scheduler that we have an outstanding task.
   scheduler_->Schedule(GetTriggerConditions(kUserRequest));
 
   if (availability == RequestAvailability::DISABLED_FOR_OFFLINER) {
     // Mark attempt started (presuming it is disabled for background offliner
     // because foreground offlining is happening).
     queue_->MarkAttemptStarted(
         request.request_id(),
         base::Bind(&RequestCoordinator::MarkAttemptDone,
                    weak_ptr_factory_.GetWeakPtr(), request.request_id(),
@@ skipping 512 matching lines @@
 
 ClientPolicyController* RequestCoordinator::GetPolicyController() {
   return policy_controller_.get();
 }
 
 void RequestCoordinator::Shutdown() {
   network_quality_estimator_ = nullptr;
 }
 
 }  // namespace offline_pages