Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2521323005: Revert of [inspector] make console.assert much faster (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
kozy, dgozman, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] make console.assert much faster (patchset #3 id:40001 of https://codereview.chromium.org/2505493002/ ) Reason for revert: Speculative revert as there seems to be a layout test crash: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11585 Please reland if it doesn't get green. Original issue's description: > [inspector] make console.assert much faster > > New console.assert implementation is faster then custom user implementation. > > BUG=chromium:663845 > R=dgozman@chromium.org > > Committed: https://crrev.com/f658e41d864267fb9e99ea76faa7758b0b63d5c9 > Cr-Commit-Position: refs/heads/master@{#41227} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:663845 Committed: https://crrev.com/c1622945f71d52817568b6f830d138914b604d8a Cr-Commit-Position: refs/heads/master@{#41231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -194 lines) Patch
M src/inspector/v8-console.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M test/debugger/debug/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
D test/inspector/runtime/console-assert.js View 1 chunk +0 lines, -24 lines 0 comments Download
D test/inspector/runtime/console-assert-expected.txt View 1 chunk +0 lines, -147 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [inspector] make console.assert much faster
4 years ago (2016-11-23 15:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521323005/1
4 years ago (2016-11-23 15:53:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 15:53:50 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 15:54:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1622945f71d52817568b6f830d138914b604d8a
Cr-Commit-Position: refs/heads/master@{#41231}

Powered by Google App Engine
This is Rietveld 408576698