Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: src/inspector/v8-console.cc

Issue 2521323005: Revert of [inspector] make console.assert much faster (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/debugger/debug/debug-script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-console.cc
diff --git a/src/inspector/v8-console.cc b/src/inspector/v8-console.cc
index 07a29efa2da0062f770892e449313e8c40698cc7..fee61177e7a134183ca4208aaaeaed831b85d1c7 100644
--- a/src/inspector/v8-console.cc
+++ b/src/inspector/v8-console.cc
@@ -714,28 +714,6 @@
createBoundFunctionProperty(context, console, "timeStamp",
V8Console::timeStampCallback);
- const char* jsConsoleAssert =
- "(function(){\n"
- " var originAssert = this.assert;\n"
- " originAssert.apply = Function.prototype.apply;\n"
- " this.assert = assertWrapper;\n"
- " assertWrapper.toString = () => originAssert.toString();\n"
- " function assertWrapper(){\n"
- " if (!!arguments[0]) return;\n"
- " originAssert.apply(null, arguments);\n"
- " }\n"
- "})";
-
- v8::Local<v8::String> assertSource = toV8String(isolate, jsConsoleAssert);
- V8InspectorImpl* inspector = inspectedContext->inspector();
- v8::Local<v8::Value> setupFunction;
- if (inspector->compileAndRunInternalScript(context, assertSource)
- .ToLocal(&setupFunction) &&
- setupFunction->IsFunction()) {
- inspector->callFunction(v8::Local<v8::Function>::Cast(setupFunction),
- context, console, 0, nullptr);
- }
-
if (hasMemoryAttribute)
console->SetAccessorProperty(
toV8StringInternalized(isolate, "memory"),
« no previous file with comments | « no previous file | test/debugger/debug/debug-script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698