Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2521293002: [wasm] Move and refactor position to location translation (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move and refactor position to location translation The GetPositionInfo function only operates on WasmCompiledModule, so it should be a method of that class. This CL also splits the method in two, such that I can reuse the GetContainingFunction method for breakpoint support. R=titzer@chromium.org BUG=chromium:613110 Committed: https://crrev.com/de52d865a0ca21ce1d140eef8dad53b129ce89d2 Cr-Commit-Position: refs/heads/master@{#41191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -36 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/wasm/wasm-objects.cc View 1 chunk +39 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Clemens Hammacher
4 years, 1 month ago (2016-11-22 17:00:28 UTC) #6
titzer
On 2016/11/22 17:00:28, Clemens Hammacher wrote: lgtm, nice!
4 years, 1 month ago (2016-11-22 17:08:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521293002/1
4 years, 1 month ago (2016-11-22 17:13:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 17:16:12 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:16:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de52d865a0ca21ce1d140eef8dad53b129ce89d2
Cr-Commit-Position: refs/heads/master@{#41191}

Powered by Google App Engine
This is Rietveld 408576698