[wasm] Move asm.js offset table to compiled module

[wasm] Move asm.js offset table to compiled module

Before, the encoded variant was stored in the compiled module, and the
decoded one in the debug info (per instance).
The decoded table was a FixedArray of ByteArrays.
Now, also the decoded table is a flat ByteArray, and it encodes whether
it is encoded or decoded. This saves memory and allows to store encoded
and decoded variant in the same field. The table is automatically
decoded on the first use.

This CL also removes some unused and unimplemented methods from
WasmDebugInfo (probably merge artifacts). That class is now pretty much
empty, but we might still need it for breakpoint support.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/916a53376aa2f660eda5b434abccce09bfacd0c0
Cr-Commit-Position: refs/heads/master@{#41316}

[Clemens Hammacher, 2016-11-22 19:24:54]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:24:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:51:34]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-22 19:53:01]

Description was changed from

==========
[wasm] Move asm.js offset table to compiled module

Before, the encoded variant was stored in the compiled module, and the
decoded one in the debug info (per instance).
The decoded table was a FixedArray of ByteArrays.
Now, also the decoded table is a flat ByteArray, and it encodes whether
it is encoded or decoded. This saves memory and allows to store encoded
and decoded variant in the same field. The table is automatically
decoded on the first use.

This CL also removed some unused and unimplemented methods from
WasmDebugInfo (probably merge artifacts). That class is now pretty much
empty, but we might still need it for breakpoint support.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
[wasm] Move asm.js offset table to compiled module

Before, the encoded variant was stored in the compiled module, and the
decoded one in the debug info (per instance).
The decoded table was a FixedArray of ByteArrays.
Now, also the decoded table is a flat ByteArray, and it encodes whether
it is encoded or decoded. This saves memory and allows to store encoded
and decoded variant in the same field. The table is automatically
decoded on the first use.

This CL also removes some unused and unimplemented methods from
WasmDebugInfo (probably merge artifacts). That class is now pretty much
empty, but we might still need it for breakpoint support.

R=titzer@chromium.org, ahaas@chromium.org
==========

[ahaas, 2016-11-23 10:08:54]

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-module-builde...
File src/wasm/wasm-module-builder.cc (right):

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.cc:538: buffer.write_u8(0);
nit: I think it would be good to introduce an encoded-table-flag constant.

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-objects.cc
File src/wasm/wasm-objects.cc (right):

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-objects.cc#ne...
src/wasm/wasm-objects.cc:466: decoded_table->set(total_size - 1, 1);
same here.

[Clemens Hammacher, 2016-11-23 12:24:15]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 12:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-23 12:24:36]

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-module-builde...
File src/wasm/wasm-module-builder.cc (right):

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.cc:538: buffer.write_u8(0);
On 2016/11/23 at 10:08:54, ahaas wrote:
> nit: I think it would be good to introduce an encoded-table-flag constant.

I think here it is OK, since the comment in the live above makes it very obvious
why we append a 0.

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-objects.cc
File src/wasm/wasm-objects.cc (right):

https://codereview.chromium.org/2522953002/diff/1/src/wasm/wasm-objects.cc#ne...
src/wasm/wasm-objects.cc:466: decoded_table->set(total_size - 1, 1);
On 2016/11/23 at 10:08:54, ahaas wrote:
> same here.

Added a function-local enum to make clear the meaning of 0 and 1.

[commit-bot: I haz the power, 2016-11-23 12:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 12:52:19]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-24 13:46:33]

Ping

[ahaas, 2016-11-24 14:14:52]

On 2016/11/24 at 13:46:33, clemensh wrote:
> Ping

lgtm

[Clemens Hammacher, 2016-11-28 11:55:59]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 11:56:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 12:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 12:23:11]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-28 13:02:44]

On 2016/11/24 14:14:52, ahaas wrote:
> On 2016/11/24 at 13:46:33, clemensh wrote:
> > Ping
> 
> lgtm

lgtm

[Clemens Hammacher, 2016-11-28 13:03:11]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-11-28 13:03:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2522953002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-28 13:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 13:04:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480338191943520,
"parent_rev": "de7e6ca27c275a191b3808e108701c6644e0ca33", "commit_rev":
"4e4b4dbf6b0bb57ed14e3b354bbbcde9b9687f02"}

[commit-bot: I haz the power, 2016-11-28 13:05:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 13:05:34]

Description was changed from

==========
[wasm] Move asm.js offset table to compiled module

Before, the encoded variant was stored in the compiled module, and the
decoded one in the debug info (per instance).
The decoded table was a FixedArray of ByteArrays.
Now, also the decoded table is a flat ByteArray, and it encodes whether
it is encoded or decoded. This saves memory and allows to store encoded
and decoded variant in the same field. The table is automatically
decoded on the first use.

This CL also removes some unused and unimplemented methods from
WasmDebugInfo (probably merge artifacts). That class is now pretty much
empty, but we might still need it for breakpoint support.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
[wasm] Move asm.js offset table to compiled module

Before, the encoded variant was stored in the compiled module, and the
decoded one in the debug info (per instance).
The decoded table was a FixedArray of ByteArrays.
Now, also the decoded table is a flat ByteArray, and it encodes whether
it is encoded or decoded. This saves memory and allows to store encoded
and decoded variant in the same field. The table is automatically
decoded on the first use.

This CL also removes some unused and unimplemented methods from
WasmDebugInfo (probably merge artifacts). That class is now pretty much
empty, but we might still need it for breakpoint support.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/916a53376aa2f660eda5b434abccce09bfacd0c0
Cr-Commit-Position: refs/heads/master@{#41316}
==========

[commit-bot: I haz the power, 2016-11-28 13:05:35]

Patchset 3 (id:??) landed as
https://crrev.com/916a53376aa2f660eda5b434abccce09bfacd0c0
Cr-Commit-Position: refs/heads/master@{#41316}