Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(400)

Issue 2521263002: [MIPS] Remove explicit masks from assembly code (Closed)

Created:
2 years, 2 months ago by petarj
Modified:
2 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

[MIPS] Remove explicit masks from assembly code Remove explicit masks from assembly files, since the assembler auto- sandboxes it. Code clean-up, no functional change. NOTRY=true Committed: https://chromium.googlesource.com/native_client/src/native_client/+/cb27d1fd35d71dce84de1458243f19ef23868f75

Patch Set 1 #

Patch Set 2 : Minor change. #

Total comments: 7

Patch Set 3 : Changes per Mark's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -160 lines) Patch
M pnacl/support/setjmp_mips32.S View 1 2 2 chunks +26 lines, -105 lines 0 comments Download
M tests/infoleak/test_infoleak_mips.S View 3 chunks +5 lines, -38 lines 0 comments Download
M tests/math/set_rounding_mips.S View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/math/test_snan_no_signal_mips.S View 1 chunk +5 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
petarj
PTAL.
2 years, 2 months ago (2016-11-22 14:32:03 UTC) #3
Mark Seaborn
LGTM https://codereview.chromium.org/2521263002/diff/20001/pnacl/support/setjmp_mips32.S File pnacl/support/setjmp_mips32.S (right): https://codereview.chromium.org/2521263002/diff/20001/pnacl/support/setjmp_mips32.S#newcode20 pnacl/support/setjmp_mips32.S:20: /* The code here is grouped by instruction ...
2 years, 2 months ago (2016-11-22 19:41:40 UTC) #4
petarj
https://codereview.chromium.org/2521263002/diff/20001/pnacl/support/setjmp_mips32.S File pnacl/support/setjmp_mips32.S (right): https://codereview.chromium.org/2521263002/diff/20001/pnacl/support/setjmp_mips32.S#newcode20 pnacl/support/setjmp_mips32.S:20: /* The code here is grouped by instruction bundle. ...
2 years, 2 months ago (2016-11-23 16:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521263002/40001
2 years, 2 months ago (2016-11-23 16:04:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: nacl-win32_newlib_opt on master.tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_newlib_opt/builds/11800)
2 years, 2 months ago (2016-11-23 16:08:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521263002/40001
2 years, 2 months ago (2016-11-23 17:04:54 UTC) #13
commit-bot: I haz the power
2 years, 2 months ago (2016-11-23 17:05:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/native_client/src/native_client/+/cb27d1fd3...

Powered by Google App Engine
This is Rietveld 408576698