Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tests/infoleak/test_infoleak_mips.S

Issue 2521263002: [MIPS] Remove explicit masks from assembly code (Closed)
Patch Set: Changes per Mark's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/support/setjmp_mips32.S ('k') | tests/math/set_rounding_mips.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/infoleak/test_infoleak_mips.S
diff --git a/tests/infoleak/test_infoleak_mips.S b/tests/infoleak/test_infoleak_mips.S
index 468c852fa310ca7536a68de06d3c6eb18acb1e78..6907ba2566bb69899a671568e3c15c391f3509a2 100644
--- a/tests/infoleak/test_infoleak_mips.S
+++ b/tests/infoleak/test_infoleak_mips.S
@@ -4,8 +4,6 @@
* found in the LICENSE file.
*/
-#include "native_client/pnacl/support/nacl_mips_defs.h"
-
/*
* Receives no arguments, just clears registers.
*/
@@ -18,29 +16,23 @@ infoleak_clear_state:
mtc1 $zero, $f1
mov.d $f2, $f0
mov.d $f4, $f0
-
mov.d $f6, $f0
mov.d $f8, $f0
mov.d $f10, $f0
mov.d $f12, $f0
-
mov.d $f14, $f0
mov.d $f16, $f0
mov.d $f18, $f0
mov.d $f20, $f0
-
mov.d $f22, $f0
mov.d $f24, $f0
mov.d $f26, $f0
mov.d $f28, $f0
-
mov.d $f30, $f0
- and $ra, $ra, JUMP_MASK
jr $ra
nop
.set reorder
-
/*
* Receives:
* a0: pointer to float_regs structure
@@ -50,47 +42,22 @@ infoleak_clear_state:
.set noreorder
.globl infoleak_fetch_regs
infoleak_fetch_regs:
- and $a0, $a0, STORE_MASK
- sdc1 $f0, 0($a0)
- and $a0, $a0, STORE_MASK
- sdc1 $f2, 8($a0)
-
- and $a0, $a0, STORE_MASK
- sdc1 $f4, 16($a0)
- and $a0, $a0, STORE_MASK
- sdc1 $f6, 24($a0)
-
- and $a0, $a0, STORE_MASK
- sdc1 $f8, 32($a0)
- and $a0, $a0, STORE_MASK
+ sdc1 $f0, 0($a0)
+ sdc1 $f2, 8($a0)
+ sdc1 $f4, 16($a0)
+ sdc1 $f6, 24($a0)
+ sdc1 $f8, 32($a0)
sdc1 $f10, 40($a0)
-
- and $a0, $a0, STORE_MASK
sdc1 $f12, 48($a0)
- and $a0, $a0, STORE_MASK
sdc1 $f14, 56($a0)
-
- and $a0, $a0, STORE_MASK
sdc1 $f16, 64($a0)
- and $a0, $a0, STORE_MASK
sdc1 $f18, 72($a0)
-
- and $a0, $a0, STORE_MASK
sdc1 $f20, 80($a0)
- and $a0, $a0, STORE_MASK
sdc1 $f22, 88($a0)
-
- and $a0, $a0, STORE_MASK
sdc1 $f24, 96($a0)
- and $a0, $a0, STORE_MASK
sdc1 $f26, 104($a0)
-
- and $a0, $a0, STORE_MASK
sdc1 $f28, 112($a0)
- and $a0, $a0, STORE_MASK
sdc1 $f30, 120($a0)
-
- and $ra, $ra, JUMP_MASK
jr $ra
nop
« no previous file with comments | « pnacl/support/setjmp_mips32.S ('k') | tests/math/set_rounding_mips.S » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698