Bug fix: Translate: CLD2 imcompatibility

Bug fix: Translate: CLD2 imcompatibility

CLD2 returns zh-Hant insteaad of zh-TW, but this is an incompatible behavior.  I fixed it by simply converting it in Chromium.

Some other language codes than zh-TW/Hant are also changed, but they doesn't affect the Translate feature.

BUG=301360
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226449

[hajimehoshi, 2013-09-30 06:00:07]

Can you take a look?  Thank you in advance.

[Takashi Toyoshima, 2013-10-01 06:20:17]

https://codereview.chromium.org/25212002/diff/1/chrome/common/translate/langu...
File chrome/common/translate/language_detection_util.cc (right):

https://codereview.chromium.org/25212002/diff/1/chrome/common/translate/langu...
chrome/common/translate/language_detection_util.cc:158: language = "zh-TW";
Do you have any reason to handle them as special cases here. Can you change
CLD2::LanguageCode to return expected language names?

Anyway, at least, we should have some comments on these two conversion, "zh-CN"
and "zh-TW".

[hajimehoshi, 2013-10-02 01:13:25]

Thank you!

https://codereview.chromium.org/25212002/diff/1/chrome/common/translate/langu...
File chrome/common/translate/language_detection_util.cc (right):

https://codereview.chromium.org/25212002/diff/1/chrome/common/translate/langu...
chrome/common/translate/language_detection_util.cc:158: language = "zh-TW";
On 2013/10/01 06:20:17, Takashi Toyoshima (chromium) wrote:
> Do you have any reason to handle them as special cases here. Can you change
> CLD2::LanguageCode to return expected language names?
> 
> Anyway, at least, we should have some comments on these two conversion,
"zh-CN"
> and "zh-TW".

We decided not to update CLD2 for this.  I'll add comments.

[Takashi Toyoshima, 2013-10-02 04:25:31]

lgtm

[commit-bot: I haz the power, 2013-10-02 04:27:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/25212002/10001

[commit-bot: I haz the power, 2013-10-02 10:53:13]

Change committed as 226449