Bug fix: Translate: CLD2 imcompatibility

chrome/common/translate/language_detection_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/translate/language_detection_util.h"
 
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 134 matching lines @@
     // for Simplified Chinese.
     switch (GetCLDMajorVersion()) {
 #if !defined(CLD_VERSION) || CLD_VERSION==1
       case 1:
         language =
             LanguageCodeWithDialects(static_cast<Language>(cld_language));
         break;
 #endif
 #if !defined(CLD_VERSION) || CLD_VERSION==2
       case 2:
+        // (1) CLD2's LanguageCode returns general Chinese 'zh' for
+        // CLD2::CHINESE, but Translate server doesn't accept it. This is
+        // converted to 'zh-CN' in the same way as CLD1's
+        // LanguageCodeWithDialects.
+        //
+        // (2) CLD2's LanguageCode returns zh-Hant instead of zh-TW for
+        // CLD2::CHINESE_T. This is technically more precise for the language
+        // code of traditional Chinese, while Translate server hasn't accepted
+        // zh-Hant yet.
         if (cld_language == CLD2::CHINESE) {
           language = "zh-CN";
+        } else if (cld_language == CLD2::CHINESE_T) {
+          language = "zh-TW";
         } else {
           language =
               CLD2::LanguageCode(static_cast<CLD2::Language>(cld_language));
         }
         break;
 #endif
       default:
         NOTREACHED();
     }
   }
@@ skipping 216 matching lines @@
     case 2:
       return CLD2::DetectLanguageVersion();
 #endif
     default:
       NOTREACHED();
   }
   return "";
 }
 
 }  // namespace LanguageDetectionUtil